Date: Thu, 19 Nov 2009 09:42:19 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: Hans Petter Selasky <hselasky@freebsd.org> Subject: Re: [PATCH] Panic when inserting PCCARD Message-ID: <200911190942.19645.jhb@freebsd.org> In-Reply-To: <200911182059.35769.hselasky@freebsd.org> References: <200911182059.35769.hselasky@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 18 November 2009 2:59:33 pm Hans Petter Selasky wrote:
> Hi,
>
> I am sometimes using a PCCARD which panics the FreeBSD 9-current kernel due
to
> generating some interrupts immediately when plugged in. Can someone add the
> required checks to handle spurious interrupts on non-enabled IRQ vectors?
>
> Backtrace:
>
> pccard_intr()
> cbb_func_intr()
> intr_event_execute_handlers()
>
> --HPS
>
> sys/dev/pccard/pccard.c
>
> static void
> pccard_intr(void *arg)
> {
> struct pccard_function *pf = (struct pccard_function*) arg;
>
> + if (pf == NULL || pf->intr_handler == NULL) return;
> pf->intr_handler(pf->intr_handler_arg);
> }
I don't think 'pf' can ever be NULL here. However, the second check might be
valid. Perhaps Warner (imp@) has a comment though?
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911190942.19645.jhb>