Date: Wed, 28 Jan 2015 20:25:02 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Roman Divacky <rdivacky@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r277841 - head/contrib/amd/hlfsd Message-ID: <874F65B6-0C1A-4230-B277-119C31BA31D7@FreeBSD.org> In-Reply-To: <20150128190422.GA58164@vlakno.cz> References: <201501281819.t0SIJQG4073269@svn.freebsd.org> <20150128190422.GA58164@vlakno.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 28 Jan 2015, at 20:04, Roman Divacky <rdivacky@freebsd.org> wrote: > On Wed, Jan 28, 2015 at 06:19:26PM +0000, Dimitry Andric wrote: >> Author: dim >> Date: Wed Jan 28 18:19:25 2015 >> New Revision: 277841 >> URL: https://svnweb.freebsd.org/changeset/base/277841 >> >> Log: >> Fix the following clang 3.6.0 warning in contrib/amd/hlfsd/homedir.c: >> >> contrib/amd/hlfsd/homedir.c:497:8: error: address of array 'buf' will >> always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] >> if (!buf || buf[0] == '\0') >> ~^~~ >> >> In the affected function, 'buf' is declared as an array of char, so it >> can never be null. Remove the unecessary check. ... > Given that this is a contributed code - have you sent the fix > upstream? Also, upstream seems to have newer versions of this... Apparently upstream fixed this about six years ago: http://git.fsl.cs.sunysb.edu/?p=am-utils-6.2.git;a=commitdiff;h=e6301006ef97d31745f9ffbb17c58cb39d18c6aa#patch9 The last real import for am-utils was about 7 year ago. Maybe it's time for an update, if it is still actively used. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTJN5IACgkQsF6jCi4glqM+RQCfTspEEJW1+ngT+rMNL/YkTf8k rncAoP5nCInKY3RPtJPIVkV6JB3mmETO =iWHd -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?874F65B6-0C1A-4230-B277-119C31BA31D7>