Date: Sat, 15 Dec 2001 09:59:48 -0800 From: Conrad Minshall <conrad@apple.com> To: Jordan Hubbard <jkh@winston.freebsd.org>, Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: hackers@freebsd.org Subject: Re: NFS: How to make FreeBSD fall on its face in one easy step Message-ID: <l03130301b84138dfba03@[17.219.180.26]> In-Reply-To: <89102.1008197808@winston.freebsd.org> References: Message from Poul-Henning Kamp <phk@critter.freebsd.dk> "of Wed, 12 Dec 2001 21:39:11 %2B0100." <63529.1008189551@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
At 2:56 PM -0800 12/12/01, Jordan Hubbard wrote:
>> The only thing I get is a math exception because "closeprob" is zero
>> since no -c option was given.
>>
>> Can you provide some sample parameters please ?
>
>Hmmm, how strange, now that I look at the code it's obvious that a
>divide by zero will occur with a zero closeprob and the docs state the
>default to be "infinity", which is obviously not the case. The
>strange part is that I ran this on freebsd.apple.com, which is running
>4.4-stable, with one parameter (the filename) exactly as I pasted in
>the usage instructions before. Perhaps all this time spent living
>next to the Macintosh in my office has induced that copy of FreeBSD to
>be more "friendly" and mask simple math errors. :-)
>
>In any case, -c 1 appears to work just fine.
That gives a close/open between each "operation". Better is to fix the
fsx.c source by inserting an "if" in main()...
diff -u -d -b -w -r1.21 fsx.c
--- fsx.c 2001/12/11 23:27:20 1.21
+++ fsx.c 2001/12/15 15:31:19
@@ -701,6 +701,7 @@
testcalls++;
+ if (closeprob)
closeopen = (rv >> 3) < (1 << 28) / closeprob;
if (debugstart > 0 && testcalls >= debugstart)
--
Conrad Minshall, conrad@apple.com, 408 974-2749
Apple Computer, Mac OS X Core Operating Systems
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?l03130301b84138dfba03>