Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Nov 2016 00:31:11 +0800
From:      Marcelo Araujo <araujobsdport@gmail.com>
To:        =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@des.no>
Cc:        src-committers@freebsd.org, svn-src-head@freebsd.org, araujo@freebsd.org,  svn-src-all@freebsd.org
Subject:   Re: svn commit: r309109 - head/lib/libutil
Message-ID:  <CAOfEmZh_qZsBWhk6H4yAaW8mG02uUJ-Ow6jkBs3vbd97jg1KPg@mail.gmail.com>
In-Reply-To: <861sy0n8re.fsf@desk.des.no>
References:  <201611241450.uAOEoLA5079215@repo.freebsd.org> <CAOfEmZgexP65RKz1=WxcFBWTYGYbnSHWMzknkGAeFN=DwjBL8A@mail.gmail.com> <861sy0n8re.fsf@desk.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 25, 2016 12:27 AM, "Dag-Erling Sm=C3=B8rgrav" <des@des.no> wrote:
>
> Marcelo Araujo <araujobsdport@gmail.com> writes:
> > We have code review, we have some many ways for communication, even
> > revert a commit if needed.
>
> No.  This is the kind of mistake where the code will seem to work just
> fine and end up in a release before a user suddenly discovers that they
> have two instances of the same daemon running and trashing their data.
> If I remember correctly, the last time someone touched flopen(),
> everything worked except 'service mountd reload' stopped working.
>
> > Everybody can read the svn history.
>
> Yeah, but they don't.  And before you say MAINTAINERS, they don't read
> or respect that either.  Believe me, I have years of experience cleaning
> up after unapproved, unreviewed commits to code I maintain.  Conversely,
> another committer once reverted a commit they had reviewed and approved
> because they thought I hadn't committed it and hit 'y' blindly when
> patch told them it was already applied.
>
> DES
> --
> Dag-Erling Sm=C3=B8rgrav - des@des.no

Ok, I understand your frustration,  and I apologize about my previous
email, but you are a developer that most of people respect in this
community. You definitely has voice to solve it in a different way.

Best,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZh_qZsBWhk6H4yAaW8mG02uUJ-Ow6jkBs3vbd97jg1KPg>