Date: Sat, 15 May 2021 23:42:06 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Lutz Donnerhacke <lutz@donnerhacke.de> Cc: Konstantin Belousov <kostikbel@gmail.com>, Lutz Donnerhacke <donner@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup Message-ID: <67F972DE-A735-4537-8AFB-87E4E9832424@freebsd.org> In-Reply-To: <20210515223634.GA21814@belenus.iks-jena.de> References: <202105150701.14F717lf084359@gitrepo.freebsd.org> <YKAkAcYHXN7XMyoL@kib.kiev.ua> <20210515195812.GB17734@belenus.iks-jena.de> <YKArpyRTTAah4LSG@kib.kiev.ua> <20210515205133.GA19770@belenus.iks-jena.de> <YKA9jrWPkeCUgwPf@kib.kiev.ua> <20210515223634.GA21814@belenus.iks-jena.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 May 2021, at 23:36, Lutz Donnerhacke <lutz@donnerhacke.de> wrote: >=20 > On Sun, May 16, 2021 at 12:30:54AM +0300, Konstantin Belousov wrote: >>> The LIBALIAS_LOCK_ASSERT and the variable declarations were not = moved. >> So you changed some style, but left the large violation in place. >=20 > This cleanup is a preparation to fix various issues in this code. > So yes, the change was intentionally limited to style issues. >=20 > Mixing style and functional changes makes it very hard to track down a > broken behavior to a single commit. This change is huge, it must not = break > anything. I think you two are talking past each other. kib@=E2=80=99s point is = that some of the changes made in this commit were style *changes* not style *fixes* (i.e. = the code was compliant before, you=E2=80=99ve just changed it from one = acceptable formatting to another), and that there were instances of significant = style violations *not* fixed (e.g. the assertion macro before variable = declarations pointed out). He is not talking about functional violations, only style = ones. However, in your defence, your original commit did not claim to fix = *all* style violations, only "most annoying style errors", though that doesn=E2=80=99t= account for unnecessary churn as seen with the blank lines at the starts of = functions. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?67F972DE-A735-4537-8AFB-87E4E9832424>