Date: Wed, 22 Aug 2001 00:46:25 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <XFMail.010822004625.jhb@FreeBSD.org> In-Reply-To: <20010822150135.X5785-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22-Aug-01 Bruce Evans wrote: > On Tue, 21 Aug 2001, John Baldwin wrote: > >> jhb 2001/08/21 15:55:20 PDT >> >> Modified files: >> sys/kern kern_shutdown.c >> Log: >> Allow one to restart from a panic in DDB by clearing the panicstr >> variable to NULL. Note that since panic() is marked with __dead2, this >> has somewhat unpredictable results at best. > > Such as "never" working? :-) On i386's panic() has no function epilogue > or return statement, so you have to do these manually to get it to > return. Then the caller may be missing stack cleanups... The easiest > workaround is to declare panic() as returning, but this will cause > lots of compiler warnings. It works sometimes. :) Perhaps what I should do is wrap this in some option (RESTARTABLE_PANICS maybe) and if it is on turn off _dead2 on panic(). > Bruce -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010822004625.jhb>