Date: Tue, 14 May 2002 19:01:00 -0700 From: Peter Wemm <peter@wemm.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Peter Jeremy <peter.jeremy@alcatel.com.au>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c Message-ID: <20020515020100.48ED1380F@overcee.wemm.org> In-Reply-To: <XFMail.20020514211932.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > > On 14-May-2002 Peter Jeremy wrote: > > On 2002-May-11 14:49:39 -0700, Peter Wemm <peter@FreeBSD.ORG> wrote: > >> Save about 60 bytes by #define memcpy __builtin_memcpy and removing > >> the function we provided. Restore the Keyboard: yes/no printf for the > >> probe diagnostics. We end up with 40 bytes free. > > > > More potential savings: > > - Change dev_nm definition to "const char dev_nm[4][] = ..." saves 7 bytes. > > This amounts to saving 20 bytes of pointers, but the code bloats by > > 13 bytes because of reversion from register-indirect to direct addressing > > of dev_nm in several places. (Using [3] instead of [4] actually makes > > things worse because *3 isn't possible in the R/I/M byte). > > - Change dev_maj defn to "const unsigned char dev_maj[]" saves 15 bytes. > > These and other changes suggested sound good to me. No objections from me if > you commit them. IMHO, as long as it works, go right ahead. :-) Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020515020100.48ED1380F>