Date: Wed, 9 Nov 2005 00:42:37 +0300 From: Yar Tikhiy <yar@FreeBSD.org> To: "Ralf S. Engelschall" <rse@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d pf Message-ID: <20051108214237.GB50391@comp.chem.msu.su> In-Reply-To: <200511031317.jA3DHneM091119@repoman.freebsd.org> References: <200511031317.jA3DHneM091119@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 03, 2005 at 01:17:49PM +0000, Ralf S. Engelschall wrote: > rse 2005-11-03 13:17:49 UTC > > FreeBSD src repository > > Modified files: > etc/rc.d pf > Log: > There is no need to explicitly add "status" to $extra_commands in > the /etc/rc.d/pf script as it is implicitly added by /etc/rc.subr's > run_rc_command() because of the existing $pf_program. > > Submitted by: Christoph Schug <chris@schug.net> > MFC after: 1 week > > Revision Changes Path > 1.11 +1 -1 src/etc/rc.d/pf I'm afraid you were relying on evil side-effects of the variable being named *_program. Those side-effect have been eliminated since rc.subr rev. 1.42. Now "status" doesn't appear among rc.d/pf valid arguments: vpc7# sh /etc/rc.d/pf Usage: /etc/rc.d/pf [fast|force|one](start|stop|restart|rcvar|check|reload|resync) I might be wrong, but it seems to me that your change to rc.d/pf should be backed out. The point is that the default "status" method is for rc.d scripts that handle startup and shutdown of conventional daemons, and not for custom tasks like the pf case. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051108214237.GB50391>