Date: Mon, 21 Oct 2013 08:46:14 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: sbruno@freebsd.org Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: gperf/src/options.cc -- quiesce clang warnings -Wlogical-op-parentheses Message-ID: <95F9CC95-2A34-40C6-A04A-3B2360B6E4DB@FreeBSD.org> In-Reply-To: <1382327452.2610.5.camel@localhost> References: <1382327452.2610.5.camel@localhost>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Oct 21, 2013, at 05:50, Sean Bruno <sean_bruno@yahoo.com> wrote: > gperf has some clang warnings that seem to be harmless, but annoying > regarding some of the logical operations around detecting ascii chars: > > c++ -O2 -pipe -I/usr/obj/usr/src/tmp/legacy/usr/include -Wno-c > ++11-extensions -I/usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/lib > -I/usr/src/gnu/usr.bin/g > perf -c /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/options.cc > /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/options.cc:284:27: > warning: '&&' within '||' [-Wlogical-op-parentheses] > if (*arg >= 'A' && *arg <= 'Z' || *arg >= 'a' && *arg <= 'z') > ~~~~~~~~~~~~^~~~~~~~~~~~~~ ~~ For contributed code, let's just turn the warnings off instead. There is almost no end to the amount of work you could spend on fixing warnings in GNU code... :-) -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlJkzbYACgkQsF6jCi4glqMHHgCfScwz1Vmplg6vbaHJ98A9oAux +AQAnRVv18jjeA9pxgTlG8WPNqFIXcZE =b2jA -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95F9CC95-2A34-40C6-A04A-3B2360B6E4DB>