Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 09 Aug 2018 12:09:41 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        Kyle Evans <kevans@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r337546 - head/sys/kern
Message-ID:  <1533838181.9860.119.camel@freebsd.org>
In-Reply-To: <201808091753.w79HrJsY076268@repo.freebsd.org>
References:  <201808091753.w79HrJsY076268@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2018-08-09 at 17:53 +0000, Kyle Evans wrote:
> Author: kevans
> Date: Thu Aug  9 17:53:18 2018
> New Revision: 337546
> URL: https://svnweb.freebsd.org/changeset/base/337546
> 
> Log:
>   subr_prf: Use "sizeof current_boot_tag" instead
> 
> Modified:
>   head/sys/kern/subr_prf.c
> 
> Modified: head/sys/kern/subr_prf.c
> =====================================================================
> =========
> --- head/sys/kern/subr_prf.c	Thu Aug  9 17:47:47 2018	(
> r337545)
> +++ head/sys/kern/subr_prf.c	Thu Aug  9 17:53:18 2018	(
> r337546)
> @@ -1040,7 +1040,7 @@ msgbufinit(void *ptr, int size)
>  	/* Attempt to fetch kern.boot_tag tunable on first mapping
> */
>  	if (!msgbufmapped)
>  		TUNABLE_STR_FETCH("kern.boot_tag", current_boot_tag,
> -		    BOOT_TAG_SZ + 1);
> +		    sizeof current_boot_tag);

Style(9) mandates parens with sizeof.

-- Ian

>  	msgbufp = (struct msgbuf *)(cp + size);
>  	msgbuf_reinit(msgbufp, cp, size);
>  	msgbuf_addstr(msgbufp, -1, current_boot_tag, 0);
> 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1533838181.9860.119.camel>