Date: Sun, 14 Apr 2013 21:17:39 -0700 From: Neel Natu <neelnatu@gmail.com> To: Julian Elischer <julian@freebsd.org> Cc: svn-src-projects@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org>, Neel Natu <neel@freebsd.org> Subject: Re: svn commit: r249353 - projects/bhyve_svm/sys/amd64/vmm/amd Message-ID: <CAFgRE9G9%2BH7FWfCO5ryQ8NUtmOwVbS87wG%2BqzSqCko-h4xQ3rQ@mail.gmail.com> In-Reply-To: <516B73A5.6000909@freebsd.org> References: <201304110652.r3B6qJmP055359@svn.freebsd.org> <516B73A5.6000909@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Julian, On Sun, Apr 14, 2013 at 8:27 PM, Julian Elischer <julian@freebsd.org> wrote: > On 4/11/13 2:52 PM, Neel Natu wrote: > >> Author: neel >> Date: Thu Apr 11 06:52:19 2013 >> New Revision: 249353 >> URL: http://svnweb.freebsd.org/**changeset/base/249353<http://svnweb.freebsd.org/changeset/base/249353>; >> >> Log: >> Provide functions to manipulate the guest state in the VMCB. >> Submitted by: Anish Gupta (akgupt3@gmail.com) >> >> Added: >> projects/bhyve_svm/sys/amd64/**vmm/amd/vmcb.c (contents, props >> changed) >> Modified: >> projects/bhyve_svm/sys/amd64/**vmm/amd/vmcb.h >> >> Added: projects/bhyve_svm/sys/amd64/**vmm/amd/vmcb.c >> ==============================**==============================** >> ================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ projects/bhyve_svm/sys/amd64/**vmm/amd/vmcb.c Thu Apr 11 06:52:19 >> 2013 (r249353) >> @@ -0,0 +1,383 @@ >> +/*- >> + * Copyright (c) 2013 Anish Gupta (akgupt3@gmail.com) >> + * All rights reserved. >> + * >> + * Redistribution and use in source and binary forms, with or without >> + * modification, are permitted provided that the following conditions >> + * are met: >> + * 1. Redistributions of source code must retain the above copyright >> + * notice, this list of conditions and the following disclaimer. >> + * 2. Redistributions in binary form must reproduce the above copyright >> + * notice, this list of conditions and the following disclaimer in the >> + * documentation and/or other materials provided with the >> distribution. >> + * >> + * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND >> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE >> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR >> PURPOSE >> + * ARE DISCLAIMED. IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE >> LIABLE >> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >> CONSEQUENTIAL >> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE >> GOODS >> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) >> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, >> STRICT >> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY >> WAY >> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF >> + * SUCH DAMAGE. >> + * >> + * $FreeBSD$ >> + */ >> + >> +#include <sys/cdefs.h> >> +__FBSDID("$FreeBSD$"); >> + >> +#include <sys/param.h> >> +#include <sys/systm.h> >> +#include <sys/cpuset.h> >> + >> +#include <machine/segments.h> >> +#include <machine/specialreg.h> >> +#include <machine/vmm.h> >> + >> +#include "vmcb.h" >> > > about here there should be a comment explianing what a VMCB is and giving > background information.. > > Fixed in r249493. > This is true for a lot of files being added these days.. I just picked on > this one randomly. No problem. best Neel > > > Julian > > > > + >> +/* >> + * Initialize SVM h/w context i.e. the VMCB control and saved state >> areas. >> + */ >> +int >> > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFgRE9G9%2BH7FWfCO5ryQ8NUtmOwVbS87wG%2BqzSqCko-h4xQ3rQ>