Date: Tue, 20 Mar 2012 18:00:50 +0100 From: Davide Italiano <davide.italiano@gmail.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, George Neville-Neil <gnn@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233045 - in head/sys: conf kern Message-ID: <CACYV=-Fpm%2B3jYZc31DswSzj=ccWdYMnYrDSU5-6K=XwmZY9neA@mail.gmail.com> In-Reply-To: <20120320143611.GH30704@FreeBSD.org> References: <201203162032.q2GKWBRV033715@svn.freebsd.org> <20120319194431.GD30704@FreeBSD.org> <CACYV=-EmbDNep1rPwF6jfHB2M8JuhLDFvrsvZoBMuVB7kOC1bA@mail.gmail.com> <CACYV=-HnKmkcw-p2i9o_VyKGkp6V5yzO0B61uCBOAebg=VHd-A@mail.gmail.com> <20120320143611.GH30704@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2012/3/20 Gleb Smirnoff <glebius@freebsd.org>: > On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote: > D> >> These indented ifdefs look like a major violation of style used throughout > D> >> the FreeBSD kernel code. Can you please keep with common style? > D> >> > D> > > D> > Heh, > D> > sorry, also Juli Mallet noticed this, I'm writing a fix for this and > D> > after I'll have approval from my mentor I'll commit. > > Looks okay, apart from additional empty line in NOTES. Isn't single > empty line enough? > > -- > Totus tuus, Glebius. Well, I removed that in my previous commit. It was a mistake. But if you think it's ok to remove that line, I have no objections on this. Davide
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-Fpm%2B3jYZc31DswSzj=ccWdYMnYrDSU5-6K=XwmZY9neA>