Date: Sun, 10 Oct 2004 17:36:52 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Takahashi Yoshihiro <nyan@jp.FreeBSD.org> Cc: sos@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_pc98.c src/sys/dev/ata ata-all.h ata-cbus.c ata-disk.c Message-ID: <89782.1097422612@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 09 Oct 2004 02:39:58 %2B0900." <20041009.023958.41719880.nyan@jp.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20041009.023958.41719880.nyan@jp.FreeBSD.org>, Takahashi Yoshihiro writes: >In article <200410071737.i97Hb9TU038301@repoman.freebsd.org> >Søren Schmidt <sos@FreeBSD.org> writes: > >> sos 2004-10-07 17:37:09 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/geom geom_pc98.c >> sys/dev/ata ata-all.h ata-cbus.c ata-disk.c >> Log: >> Move the PC98 specific geometry "gunk" to geom_pc98.c where it belongs. >> This also adds support for bigger disks on the controller I have access to, >> and maybe others if I understood the adhoc methods used on those. >> >> Those with more PC98 bigdrive controllers it is hereby invited to add/fix >> support for those in geom_pc98.c and not using #ifdef PC98 all over the place. > >This broke non-ATA disk supports. We need to use different way for >geometry translation between ATA and non-ATA disks. And, your >'BigDrive' support has some problems, it cannot use 'BigDrive' as root >filesystem and it is incompatibility with the other OSs. Then conditionalize the code in geom_pc98 on the provider name starting with "ad". All PC98 disk layout relevant code should be in geom_pc98 and not in diskdrivers. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?89782.1097422612>