Date: Sat, 01 Nov 2008 10:46:07 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: kostikbel@gmail.com Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184515 - in head/sys: conf modules/rl pci Message-ID: <20081101.104607.1844477909.imp@bsdimp.com> In-Reply-To: <20081101103025.GU18100@deviant.kiev.zoral.com.ua> References: <200810312324.m9VNOE88093395@svn.freebsd.org> <20081101103025.GU18100@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20081101103025.GU18100@deviant.kiev.zoral.com.ua>
Kostik Belousov <kostikbel@gmail.com> writes:
: On Fri, Oct 31, 2008 at 11:24:14PM +0000, Warner Losh wrote:
: > Author: imp
: > Date: Fri Oct 31 23:24:13 2008
: > New Revision: 184515
: > URL: http://svn.freebsd.org/changeset/base/184515
: >
: > Log:
: > Add RL_TWISTER_ENABLE option. This enables the magic bits to do long
: > cable tuning. This has helped in some installations for hardware
: > deployed by a former employer. Made optional because the lists aren't
: > full of complaints about these cards... even when they were wildly
: > popular.
: >
: > Reviewed by: attilio@, jhb@, trhodes@ (all an older version of the patch)
: >
: > Modified:
: > head/sys/conf/options
: > head/sys/modules/rl/Makefile
: > head/sys/pci/if_rl.c
: > head/sys/pci/if_rlreg.h
: >
: > Modified: head/sys/conf/options
: > ==============================================================================
: > --- head/sys/conf/options Fri Oct 31 18:40:35 2008 (r184514)
: > +++ head/sys/conf/options Fri Oct 31 23:24:13 2008 (r184515)
: > @@ -672,6 +672,9 @@ ED_SIC opt_ed.h
: > # bce driver
: > BCE_DEBUG opt_bce.h
: >
: > +# rl driver
: > +RL_TWISTER_ENABLE opt_rl.h
: Would it make sense to compile it unconditionally, but enable by a sysctl
: or loader knob ?
That's a good idea. Given the level of problems here, and my lack of
time, I'll leave it to someone else I think.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081101.104607.1844477909.imp>