Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 23 Jan 2012 17:12:46 +0900 (JST)
From:      Kohji Okuno <okuno.kohji@jp.panasonic.com>
To:        freebsd-current@freebsd.org
Subject:   Is UPS_PORT_POWER wrong?
Message-ID:  <20120123.171246.321689433999174416.okuno.kohji@jp.panasonic.com>
next in thread | raw e-mail | index | archive | help 
Hi HPS,

I think that UPS_PORT_POWER and UPS_PORT_LINK_STATE overlap.
And, in xhci.c you set UPS_PORT_POWER as folows.

When UPS_PORT_POWER is set, UPS_PORT_LINK_STATE_GET() macro will
return incorrect value.

                if (v & XHCI_PS_PP) {
                        /*
                         * The USB 3.0 RH is using the
                         * USB 2.0's power bit
                         */
                        i |= UPS_PORT_POWER;
                }

Regards,
 Kohji Okuno

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120123.171246.321689433999174416.okuno.kohji>