Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 May 2009 03:08:37 +0000 (UTC)
From:      Kip Macy <kmacy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r192620 - user/kmacy/releng_7_2_fcs/sys/dev/hwpmc
Message-ID:  <200905230308.n4N38bOC027153@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kmacy
Date: Sat May 23 03:08:36 2009
New Revision: 192620
URL: http://svn.freebsd.org/changeset/base/192620

Log:
  fix locking in loggiing loop

Modified:
  user/kmacy/releng_7_2_fcs/sys/dev/hwpmc/hwpmc_logging.c

Modified: user/kmacy/releng_7_2_fcs/sys/dev/hwpmc/hwpmc_logging.c
==============================================================================
--- user/kmacy/releng_7_2_fcs/sys/dev/hwpmc/hwpmc_logging.c	Sat May 23 02:48:15 2009	(r192619)
+++ user/kmacy/releng_7_2_fcs/sys/dev/hwpmc/hwpmc_logging.c	Sat May 23 03:08:36 2009	(r192620)
@@ -266,10 +266,8 @@ pmclog_loop(void *arg)
 	 * struct's queue.  The loop is exited when the log file
 	 * is deconfigured.
 	 */
-
-	mtx_lock_spin(&po->po_mtx);
 	for (;;) {
-
+		mtx_lock_spin(&po->po_mtx);
 		/* check if we've been asked to exit */
 		if ((po->po_flags & PMC_PO_OWNS_LOGFILE) == 0) {
 			mtx_unlock_spin(&po->po_mtx);
@@ -335,7 +333,7 @@ pmclog_loop(void *arg)
 
 		mtx_lock_spin(&pmc_bufferlist_mtx);
 		TAILQ_INSERT_HEAD(&pmc_bufferlist, lb, plb_next);
-
+		mtx_unlock_spin(&pmc_bufferlist_mtx);
 		lb = NULL;
 	}
 	mtx_lock_spin(&po->po_mtx);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905230308.n4N38bOC027153>