Date: Tue, 13 Jan 2009 21:57:12 +0100 From: Rafal Jaworowski <raj@semihalf.com> To: Alan Cox <alc@cs.rice.edu> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187151 - head/sys/powerpc/booke Message-ID: <496D0028.7080302@semihalf.com> In-Reply-To: <496CE1D6.6000101@cs.rice.edu> References: <200901131615.n0DGFnuC008182@svn.freebsd.org> <496CE1D6.6000101@cs.rice.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Alan Cox wrote: > Both the BookE and MIPS pmap modules need to have their get_pv_entry() > functions updated. Their implementations of get_pv_entry() look like > what I would expect to find in FreeBSD 4. For example, the modern > equivalent of pmap_collect() is performed synchronously from > get_pv_entry() rather than asynchronously as a side-effect of waking the > page daemon. As a result of this mismatch, there is no > pmap_collect()-like support in HEAD for either BookE or MIPS. This > could cause either to crash under memory pressure. > > The simplest correct implementation of get_pv_entry() can be found in > the IA64 pmap module. You could cut-and-paste all but the body of the > inner loop. (amd64 and i386 are complicated by their efforts to save > memory.) Alan, Thanks for bringing it out and the hints. I'll take a look and try to improve this for the BookE. Rafal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?496D0028.7080302>