Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 5 Oct 2014 20:19:06 +0200
From:      Stefan Farfeleder <stefanf@FreeBSD.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        src-committers@freebsd.org, Mateusz Guzik <mjg@FreeBSD.org>, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@FreeBSD.org>, Konstantin Belousov <kib@freebsd.org>, svn-src-head@freebsd.org
Subject:   Re: svn commit: r272505 - in head/sys: kern sys
Message-ID:  <20141005181906.GB1890@mole.fafoe.narf.at>
In-Reply-To: <20141005171617.GB26076@kib.kiev.ua>
References:  <201410040808.s9488uAI099166@svn.freebsd.org> <42180557-0119-4597-9492-662E1671A840@FreeBSD.org> <20141005163953.GA1890@mole.fafoe.narf.at> <20141005171617.GB26076@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 05, 2014 at 08:16:17PM +0300, Konstantin Belousov wrote:
> On Sun, Oct 05, 2014 at 06:39:54PM +0200, Stefan Farfeleder wrote:
> > On Sat, Oct 04, 2014 at 02:21:54PM +0000, Bjoern A. Zeeb wrote:
> > > 
> > > On 04 Oct 2014, at 08:08 , Mateusz Guzik <mjg@FreeBSD.org> wrote:
> > > 
> > > > Author: mjg
> > > > Date: Sat Oct  4 08:08:56 2014
> > > > New Revision: 272505
> > > > URL: https://svnweb.freebsd.org/changeset/base/272505
> > > > 
> > > > Log:
> > > >  Plug capability races.
> > > > 
> > > >  fp and appropriate capability lookups were not atomic, which could result in
> > > >  improper capabilities being checked.
> > > > 
> > > >  This could result either in protection bypass or in a spurious ENOTCAPABLE.
> > > > 
> > > >  Make fp + capability check atomic with the help of sequence counters.
> > > > 
> > > >  Reviewed by:	kib
> > > >  MFC after:	3 weeks
> > > > 
> > > > Modified:
> > > >  head/sys/kern/kern_descrip.c
> > > >  head/sys/sys/filedesc.h
> > > > ???
> > > 
> > > 
> > > This file is included from user space.  There is no opt_capsicum.h there.
> > > Including an opt_* in the header file seems wrong in a lot of ways usually.
> > > 
> > > I tried to add a bandaid for the moment with r272523 which (to be honest) makes it worse.
> > > 
> > > This needs a better fix.
> > 
> > Hi,
> > 
> > this also breaks the nvidia-driver port (also with your fix).
> 
> Is the breakage due to missing opt_capsicum.h file ?
> If yes, what I proposed, i.e. making the new member unconditional,
> should fix it without changes to the module build system.

Yes, it breaks due to the missing file.

Stefan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141005181906.GB1890>