Date: Mon, 16 May 2005 05:37:08 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.org> To: current@FreeBSD.org Subject: HEAD UP: correct type of addrinfo.ai_addrlen and netent.n_net Message-ID: <yge8y2gb4zv.wl%ume@mahoroba.org> References: <200505152015.j4FKFGsI021150@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Multipart_Mon_May_16_05:37:07_2005-1
Content-Type: text/plain; charset=US-ASCII
Hi,
I've committed to correct type of ai_addrlen member of struct addrinfo
and n_net member of struct netent. Though it affects to 64 bit arch,
I believe it doesn't break ABI backward comatibility.
I'll remove padding for ABI backward comatibility after 2 weeks. When
padding is removed, ABI backward comatibility will be lost on 64 bit
arch.
Sincerely,
--Multipart_Mon_May_16_05:37:07_2005-1
Content-Type: message/rfc822
X-Sieve: CMU Sieve 2.2
Delivered-To: ume@freebsd.org
Delivered-To: src-committers@freebsd.org
Message-Id: <200505152015.j4FKFGsI021150@repoman.freebsd.org>
From: Hajimu UMEMOTO <ume@FreeBSD.org>
Date: Sun, 15 May 2005 20:15:15 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/include netdb.h src/lib/libc/net getaddrinfo.c
getnetbydns.c getnetbyht.c getnetbynis.c getnetnamadr.c
netdb_private.h
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-src-committers@FreeBSD.org
Precedence: bulk
X-Loop: FreeBSD.ORG
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0b5
(cheer.mahoroba.org [218.45.22.175]); Mon, 16 May 2005 05:17:10 +0900 (JST)
X-Virus-Scanned: by amavisd-new
X-Virus-Status: Clean
X-Spam-Status: No, score=-5.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00
autolearn=ham version=3.0.3
X-Spam-Checker-Version: SpamAssassin 3.0.3 (2005-04-27) on cheer.mahoroba.org
ume 2005-05-15 20:15:15 UTC
FreeBSD src repository
Modified files:
include netdb.h
lib/libc/net getaddrinfo.c getnetbydns.c getnetbyht.c
getnetbynis.c getnetnamadr.c
netdb_private.h
Log:
- The ai_addrlen of a struct addrinfo used to be a size_t, per
RFC 2553. In XNS5.2, and subsequently in POSIX-2001 and RFC
3493, it was changed to a socklen_t. And, the n_net of a
struct netent used to be an unsigned long integer. In XNS5,
and subsequently in POSIX-2001, it was changed to an uint32_t.
To accomodate for this while preserving ABI compatibility with
the old interface, we need to prepend or append 32 bits of
padding, depending on the (LP64) architecture's endianness.
- Correct 1st argument of getnetbyaddr() to uint32_t on 32
bit arch. Stay as is on 64 bit arch for ABI backward
compatibility for now.
Reviewed by: das, peter
MFC after: 2 weeks
Revision Changes Path
1.36 +46 -5 src/include/netdb.h
1.69 +4 -1 src/lib/libc/net/getaddrinfo.c
1.30 +12 -8 src/lib/libc/net/getnetbydns.c
1.15 +5 -2 src/lib/libc/net/getnetbyht.c
1.18 +7 -4 src/lib/libc/net/getnetbynis.c
1.20 +8 -3 src/lib/libc/net/getnetnamadr.c
1.9 +1 -7 src/lib/libc/net/netdb_private.h
--Multipart_Mon_May_16_05:37:07_2005-1
Content-Type: text/plain; charset=US-ASCII
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
--Multipart_Mon_May_16_05:37:07_2005-1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?yge8y2gb4zv.wl%ume>