Date: Thu, 30 Sep 2010 10:54:55 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Bernhard Froehlich <decke@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/zfsnap Makefile distinfo Message-ID: <4CA4505F.1080306@FreeBSD.org> In-Reply-To: <20100929165421.70c8064a.stas@FreeBSD.org> References: <201009291312.o8TDCTwo029078@repoman.freebsd.org> <20100929165421.70c8064a.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2010/09/30 01:54, Stanislav Sedov wrote:
> On Wed, 29 Sep 2010 13:12:29 +0000 (UTC)
> Bernhard Froehlich<decke@FreeBSD.org> mentioned:
>
>> decke 2010-09-29 13:12:29 UTC
>>
>> FreeBSD ports repository
>>
>> Modified files:
>> sysutils/zfsnap Makefile distinfo
>> Log:
>> - Update to 1.4.0
>
> It's usually beneficial if you also provide the short changelog of changes
> in the software, or at least a link to the changelog. Especially in this
> case, when maintainer wrote it clearly in the PR.
It's not an usual practice.
>>
>> PR: ports/151017
>> Submitted by: Aldis Berjoza<aldis at bsdroot dot lv> (maintainer)
>> Approved by: beat (co-mentor, implicit)
>>
>
>> |
>> | -# vim: set ts=8 sw=8:
>> | .include<bsd.port.mk>
>
> Is this one required for version update? If it was done intentionaly, it
> should be documented in the commit log. otherwise it looks like an accidential
> change.
Again, it's not a usual practice to have this in the Makefiles so the
cleanup is understandable.
--
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CA4505F.1080306>