Date: Thu, 20 Sep 2001 16:05:45 -0700 From: Peter Wemm <peter@wemm.org> To: Jonathan Lemon <jlemon@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_environment.c Message-ID: <20010920230545.B102F38FF@overcee.netplex.com.au> In-Reply-To: <200109202009.f8KK9bu88534@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jonathan Lemon wrote: > jlemon 2001/09/20 13:09:37 PDT > > Modified files: > sys/kern kern_environment.c > Log: > Add a sysctl MIB 'kern.env', that dumps the contents of the kernel > environment from the loader, as well as the kernel's compiled in static > hints. Congratulations! you have just broken kenv(1). :-( This mib was addressable by index so that a userland program could pull them out, one by one. Also, kern_envp is dynamically flipped between the loader environment or the static environment, but subr_hints.c uses either the environment *or* static_hints[] but never both. IMHO, It is bogus reporting the static hints if we're running from the environment set as it will just cause confusion. I wish you had used a different MIB rather than breaking existing, *used* functionality. (It isn't used in the tree, but it is used by a whole bunch of scripts at work where we pass stuff across from netboot and netboot+ramdisk environments) Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010920230545.B102F38FF>