Date: Fri, 1 Sep 2017 14:35:15 -0700 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Ian Lepore <ian@freebsd.org>, cem@freebsd.org, Josh Paetzel <jpaetzel@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf Message-ID: <4c48a573-d6d6-9f2f-3034-e265e5fdfe99@freebsd.org> In-Reply-To: <1504284895.41612.29.camel@freebsd.org> References: <201709011554.v81FssRG083114@repo.freebsd.org> <CAG6CVpVnEejQdE-=SLyLU__PJpuFNmC03FHnnx1Vfnv=uZN20Q@mail.gmail.com> <1504284895.41612.29.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/01/17 09:54, Ian Lepore wrote: > On Fri, 2017-09-01 at 09:06 -0700, Conrad Meyer wrote: >> Wait, why? The PR doesn't explain it any better than this commit >> message. >> >> On Fri, Sep 1, 2017 at 8:54 AM, Josh Paetzel <jpaetzel@freebsd.org> >> wrote: >>> Author: jpaetzel >>> Date: Fri Sep 1 15:54:53 2017 >>> New Revision: 323087 >>> URL: https://svnweb.freebsd.org/changeset/base/323087 >>> >>> Log: >>> Take options IPSEC out of GENERIC >>> >>> PR: 220170 >>> Submitted by: delphij >>> Reviewed by: ae, glebius >>> MFC after: 2 weeks >>> Differential Revision: D11806 > The differential revision (which should be cited using the complete url > in the commit) seems to indicate that it's because it can be kldloaded. > > This change misses the armv6 platform, where the option appears in > std.armv6, which gets included in GENERIC (and all other armv6 > configs). > > This change seems to warrant an entry in UPDATING, because it's going > to catch a lot of people by surprise. Even people with custom kernels, > if they follow the advice of the handbook and "include GENERIC" then > override things. > > -- Ian > I realize this is immediately moot because the commit has been reverted, but please remember about powerpc/conf/GENERIC64 for future such changes. This is the "GENERIC" kernel for the powerpc64 architecture, which does not have its own arch directory. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4c48a573-d6d6-9f2f-3034-e265e5fdfe99>