Date: Sat, 2 May 2020 09:16:35 +0000 From: Rene Ladan <rene@freebsd.org> To: Warner Losh <imp@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r360540 - head/stand/libofw Message-ID: <20200502091635.GA16751@freefall.freebsd.org> In-Reply-To: <202005011750.041HoMaV058949@repo.freebsd.org> References: <202005011750.041HoMaV058949@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 01, 2020 at 05:50:22PM +0000, Warner Losh wrote: > Author: imp > Date: Fri May 1 17:50:21 2020 > New Revision: 360540 > URL: https://svnweb.freebsd.org/changeset/base/360540 > > Log: > Remove more stray sparc64 ifdefs. > > Also, dmabuf appears to only be set for sparc64 case, but there was a > comment at its only use that says it was broken for some apple > adapters. #ifdef it all of that out now that nothing sets it. > > Modified: > head/stand/libofw/ofw_net.c > > Modified: head/stand/libofw/ofw_net.c > ============================================================================== > --- head/stand/libofw/ofw_net.c Fri May 1 17:17:01 2020 (r360539) > +++ head/stand/libofw/ofw_net.c Fri May 1 17:50:21 2020 (r360540) [...] > @@ -220,20 +220,6 @@ ofwn_init(struct iodesc *desc, void *machdep_hint) > #if defined(NETIF_DEBUG) > printf("ofwn_init: Open Firmware instance handle: %08x\n", netinstance); > #endif > - > -#ifndef __sparc64__ ^ Shouldn't this code always be present? > - dmabuf = NULL; > - if (OF_call_method("dma-alloc", netinstance, 1, 1, (64 * 1024), &dmabuf) > - < 0) { > - printf("Failed to allocate DMA buffer (got %p).\n", dmabuf); > - goto punt; > - } > - > -#if defined(NETIF_DEBUG) > - printf("ofwn_init: allocated DMA buffer: %p\n", dmabuf); > -#endif > -#endif > - René
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200502091635.GA16751>