Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Sep 2011 02:57:49 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        linimon@FreeBSD.org
Cc:        freebsd-bugs@FreeBSD.org, Warner Losh <imp@FreeBSD.org>, Garrett Cooper <gcooper@FreeBSD.org>
Subject:   Re: conf/160896: [nanobsd] [patch] use getopts, jobs option, delay -c usage improvements to nanobsd.sh
Message-ID:  <25F8136F-8476-4746-91A9-EAADA3C8D20F@bsdimp.com>
In-Reply-To: <201109220755.p8M7t0Vx081424@freefall.freebsd.org>

index | next in thread | previous in thread | raw e-mail

Rejecting parts of this patch.  Specifically, the delated -c stuff is bogusly implemented.  Before the change, you could have multiple -c options on the command line.  after this you can't.

Don't like how -j is implemented in this patch.  Need to think about this because it breaks some nanobsd config files that specify NANO_PMAKE command.

Other stuff looks good and it, or variations of it, will go in when we're out of the freeze.

Warner

On Sep 22, 2011, at 1:55 AM, linimon@FreeBSD.org wrote:

> Old Synopsis: [patch] use getopts, jobs option, delay -c usage improvements to nanobsd.sh
> New Synopsis: [nanobsd] [patch] use getopts, jobs option, delay -c usage improvements to nanobsd.sh
> 
> Responsible-Changed-From-To: freebsd-bugs->imp
> Responsible-Changed-By: linimon
> Responsible-Changed-When: Thu Sep 22 07:54:48 UTC 2011
> Responsible-Changed-Why: 
> Over to maintainer.
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=160896
> 
> 



home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25F8136F-8476-4746-91A9-EAADA3C8D20F>