Date: Sun, 20 Oct 2002 01:59:53 +0400 (MSD) From: Sergey Mokryshev <mokr@mokr.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: misc/44284: /etc/rc.d/ipnat does not properly call 'err' in absense of ipfilter module Message-ID: <200210192159.g9JLxrYE001054@amber.mokr.ru>
next in thread | raw e-mail | index | archive | help
>Number: 44284
>Category: misc
>Synopsis: /etc/rc.d/ipnat does not properly call 'err' in absense of ipfilter module
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Oct 19 15:10:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Sergey Mokryshev
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
Tersys
>Environment:
System: FreeBSD amber.mokr.net 5.0-CURRENT FreeBSD 5.0-CURRENT #12: Sun Oct 20 00:40:36 MSD 2002 su@amber.mokr.net:/.1/a/obj/.1/a/src/sys/AMBER_UP i386
>Description:
/etc/rc.d/ipnat miss first argument (error code) while calling
'err' routine from /etc/rc.subr
>How-To-Repeat:
echo 'ipfilter_enable="NO"' >>/etc/rc.conf
echo 'ipnat_enable="YES"' >>/etc/rc.conf
(remove options IPFILTER from kernel configuration if it is there and recompile kernel)
reboot
examine console output, there should be
Oct 20 01:05:11 amber kernel: /etc/rc: ERROR:
Oct 20 01:05:11 amber kernel: exit: Illegal number: ipnat
>Fix:
--- /tmp/ipnat.orig Sun Oct 20 01:29:50 2002
+++ ipnat Sun Oct 20 01:32:55 2002
@@ -36,8 +36,7 @@
{
# Make sure ipfilter is loaded before continuing
if ! ${SYSCTL} net.inet.ipf.fr_pass >/dev/null 2>&1; then
- err 'ipnat requires ipfilter be loaded'
- return 1
+ err 1 'ipnat requires ipfilter be loaded'
fi
return 0
}
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210192159.g9JLxrYE001054>