Date: Thu, 05 Dec 2002 11:02:47 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Alfred Perlstein <alfred@FreeBSD.org> Cc: tanimura@FreeBSD.org, current@FreeBSD.org, Kris Kennaway <kris@obsecurity.org>, Lars Eggert <larse@ISI.EDU> Subject: Re: Lock order reversals in sys_pipe.c and kern_sig.c Message-ID: <XFMail.20021205110247.jhb@FreeBSD.org> In-Reply-To: <20021204231245.GH58155@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04-Dec-2002 Alfred Perlstein wrote:
> * Lars Eggert <larse@ISI.EDU> [021204 15:04] wrote:
>>
>> FYI, just got a similar one yesterday on an up-to-date -current:
>>
>> lock order reversal
>> 1st 0xc784d700 pipe mutex (pipe mutex) @ /usr/src/sys/kern/sys_pipe.c:465
>> 2nd 0xc0513840 sigio lock (sigio lock) @ /usr/src/sys/kern/kern_sig.c:2225
>
> Since no one has given me the traceback based on the patch I posted
> earlier I have ceased to care about the "problem". If someone
> seriously cares they will run with my patch and post a backtrace.
Your patch doesn't work because it makes a bogus assumption. A better
try would be this:
Index: subr_witness.c
===================================================================
RCS file: /usr/cvs/src/sys/kern/subr_witness.c,v
retrieving revision 1.130
diff -u -r1.130 subr_witness.c
--- subr_witness.c 11 Nov 2002 16:36:20 -0000 1.130
+++ subr_witness.c 18 Nov 2002 20:42:35 -0000
@@ -205,6 +205,9 @@
{ "uidinfo hash", &lock_class_mtx_sleep },
{ "uidinfo struct", &lock_class_mtx_sleep },
{ NULL, NULL },
+ { "sigio lock", &lock_class_mtx_sleep },
+ { "pipe mutex", &lock_class_mtx_sleep },
+ { NULL, NULL },
/*
* spin locks
*/
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021205110247.jhb>