Date: Fri, 1 Jun 2007 21:49:16 GMT From: Paolo Pisati <piso@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 120730 for review Message-ID: <200706012149.l51LnG4Q045220@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=120730 Change 120730 by piso@piso_newluxor on 2007/06/01 21:49:02 -axe a useless comment -clear the interrupt if a filter executed, else mask the src, run the ithread and then clear th src Affected files ... .. //depot/projects/soc2006/intr_filter/sparc64/pci/psycho.c#15 edit Differences ... ==== //depot/projects/soc2006/intr_filter/sparc64/pci/psycho.c#15 (text+ko) ==== @@ -219,7 +219,6 @@ * providing two PCI buses. */ -/* XXX let's hope no one ever create a flag with this value... */ #define FAST 0x66600000 #ifdef DEBUGGER_ON_POWERFAIL @@ -990,11 +989,11 @@ struct psycho_clr *pc = arg; int res; - if (pc->pci_filter != NULL) + if (pc->pci_filter != NULL) { res = pc->pci_filter(pc->pci_arg); - else - res = FILTER_HANDLED | FILTER_SCHEDULE_THREAD; - PSYCHO_WRITE8(pc->pci_sc, pc->pci_clr, 0); + PSYCHO_WRITE8(pc->pci_sc, pc->pci_clr, 0); + } else + res = FILTER_SCHEDULE_THREAD; return (res); } @@ -1009,6 +1008,7 @@ (void)PSYCHO_READ8(pc->pci_sc, PSR_DMA_WRITE_SYNC); } pc->pci_handler(pc->pci_arg); + PSYCHO_WRITE8(pc->pci_sc, pc->pci_clr, 0); } static int
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706012149.l51LnG4Q045220>