Date: Tue, 18 Mar 2008 20:35:13 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Stanislav Sedov <stas@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/java/eclipseme Makefile distinfo pkg-plist Message-ID: <47E01971.4080506@FreeBSD.org> In-Reply-To: <20080318181546.GA10903@FreeBSD.org> References: <200803180100.m2I10QTD070047@repoman.freebsd.org> <20080318193855.0439b197.stas@FreeBSD.org> <20080318181546.GA10903@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Alexey Dokuchaev wrote: | On Tue, Mar 18, 2008 at 07:38:55PM +0300, Stanislav Sedov wrote: |> On Tue, 18 Mar 2008 01:00:26 +0000 (UTC) |> Pietro Cerutti <gahr@FreeBSD.org> mentioned: |> |>> gahr 2008-03-18 01:00:26 UTC |>> |>> FreeBSD ports repository |>> |>> Modified files: |>> java/eclipseme Makefile distinfo pkg-plist |>> Log: |>> - Update to 0.4.6 |>> |>> Approved by: miwi (mentor) |>> |>> Revision Changes Path |>> 1.6 +5 -8 ports/java/eclipseme/Makefile |>> http://cvsweb.FreeBSD.org/ports/java/eclipseme/Makefile.diff?r1=1.5&r2=1.6 |>> | --- ports/java/eclipseme/Makefile 2007/07/16 08:58:28 1.5 |>> | +++ ports/java/eclipseme/Makefile 2008/03/18 01:00:25 1.6 |>> | @@ -2,15 +2,13 @@ |>> | # Date created: July 22, 2004 |>> | # Whom: past@ebs.gr |>> | # |>> | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/java/eclipseme/Makefile,v 1.5 2007/07/16 08:58:28 pav Exp $ |>> | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/java/eclipseme/Makefile,v 1.6 2008/03/18 01:00:25 gahr Exp $ |>> | # |>> | |>> | PORTNAME= eclipseme |>> | -PORTVERSION= 0.4.5 |>> | -PORTREVISION= 3 |>> | +PORTVERSION= 0.4.6 |>> | CATEGORIES= java devel |>> | -MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} |>> | -MASTER_SITE_SUBDIR= ${PORTNAME} |>> | +MASTER_SITES= SF |>> | DISTNAME= ${PORTNAME}-${PORTVERSION} |>> | DIST_SUBDIR= eclipse |>> | |>> | @@ -31,11 +29,10 @@ RUN_DEPENDS+= ${LOCALBASE}/share/proguar |>> | .endif |>> | |>> | do-install: |>> | - @${CP} -r ${WRKSRC}/${PORTNAME}_${PORTVERSION} ${PREFIX}/eclipse/plugins/ |>> | + @${MKDIR} ${PREFIX}/eclipse/plugins |>> | + @${CP} -r ${WRKSRC}/${PORTNAME}_${PORTVERSION} ${PREFIX}/eclipse/plugins/ |> Wouldn't it be better to use COPYTREE_SHARE for that? This way it'll set correct |> permissions on files. | | Not to mention that -R should've probably be used instead or -r, and we | generally try not to mute installation of files/links (as opposed to | dirs). | | ./danfe Agreed. I will fix the -r option and switch to COPYTREE_SHARE. Thanks! - -- Pietro Cerutti gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEAREKAAYFAkfgGXAACgkQwMJqmJVx944A1QCfW9uODmUgyndez4WfIOd0ST+s cDoAoL1yjEU76+HRnLlOm1tJOXAD67Xt =Du/q -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47E01971.4080506>