Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Nov 2008 16:03:18 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r185179 - head/sys/netgraph
Message-ID:  <200811221603.mAMG3I1e022241@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Sat Nov 22 16:03:18 2008
New Revision: 185179
URL: http://svn.freebsd.org/changeset/base/185179

Log:
  Remove unneeded NULL check. At first msg can't be null here and and at second
  NG_FREE_MSG() also checks it.
  
  Found with:	Coverity Prevent(tm)

Modified:
  head/sys/netgraph/ng_base.c

Modified: head/sys/netgraph/ng_base.c
==============================================================================
--- head/sys/netgraph/ng_base.c	Sat Nov 22 15:38:24 2008	(r185178)
+++ head/sys/netgraph/ng_base.c	Sat Nov 22 16:03:18 2008	(r185179)
@@ -2853,8 +2853,7 @@ ng_generic_msg(node_p here, item_p item,
 	 */
 out:
 	NG_RESPOND_MSG(error, here, item, resp);
-	if (msg)
-		NG_FREE_MSG(msg);
+	NG_FREE_MSG(msg);
 	return (error);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811221603.mAMG3I1e022241>