Date: Wed, 14 Jul 2004 04:26:22 -0500 From: Jon Noack <noackjr@alumni.rice.edu> To: Michael Nottebrock <michaelnottebrock@gmx.net> Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: CVSUP and 5.2.1 RELEASE Message-ID: <40F4FC3E.5000808@alumni.rice.edu> In-Reply-To: <200407141056.44351.michaelnottebrock@gmx.net> References: <26075.1089753893@critter.freebsd.dk> <20040713232214.GA9507@dhcp50.pn.xcllnt.net> <p0611041abd1a49199d83@[128.113.24.47]> <200407141056.44351.michaelnottebrock@gmx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/14/04 03:56, Michael Nottebrock wrote: > On Wednesday 14 July 2004 04:24, Garance A Drosihn wrote: >> At 4:22 PM -0700 7/13/04, Marcel Moolenaar wrote: >>> On Tue, Jul 13, 2004 at 06:23:38PM -0400, Garance A Drosihn wrote: >>>> a) how about if we print a warning and exit if DESTDIR is >>>> not defined? Are there "important" uses of `make world' >>>> which do not use DESTDIR? >>> >>> My thoughts exactly. See attached patch. >> >> Actually, the target should end with some kind of failure, in case >> someone has a script that does: >> make world && do-next-thing > > Why should make world DESTDIR=/my/jail && cd etc && make distribution > DESTDIR=/my/jail fail? It won't fail. If you read the patch and thread a bit more closely you'll note that the warning and failure happen only if DESTDIR is not defined. As you are defining DESTDIR, you won't see any change in behavior/output. Jon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40F4FC3E.5000808>