Date: Sun, 16 Sep 2012 18:45:30 +0100 From: Chris Rees <utisoft@gmail.com> To: Ian Lepore <freebsd@damnhippie.dyndns.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, David Chisnall <theraven@freebsd.org>, Andrew Turner <andrew@freebsd.org>, Bruce Evans <brde@optusnet.com.au>, svn-src-head@freebsd.org Subject: Re: svn commit: r240549 - head/sys/arm/tegra Message-ID: <CADLo839RJQY6hsoryBGR382tQhfVLBRTLeJOPkNntg77KjZ4kg@mail.gmail.com> In-Reply-To: <1347817284.1114.2.camel@revolution.hippie.lan> References: <201209160755.q8G7tnMH036332@svn.freebsd.org> <20120916092818.GA81952@FreeBSD.org> <CADLo83-5zQBdf3ndBXO4qbkXJgaFPxGfE86LSDGqJ4g3k_4gkw@mail.gmail.com> <38FB39C4-7626-4D54-8197-E302BB9452D2@FreeBSD.org> <CADLo8381qBMC0TvJ8BXd29OFBcB9=R0NNi_idXi-h4OZ=DHWMA@mail.gmail.com> <1347817284.1114.2.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 September 2012 18:41, Ian Lepore <freebsd@damnhippie.dyndns.org> wrote:
> On Sun, 2012-09-16 at 18:30 +0100, Chris Rees wrote:
>> On 16 Sep 2012 16:19, "David Chisnall" <theraven@freebsd.org> wrote:
>> >
>> > On 16 Sep 2012, at 10:37, Chris Rees wrote:
>> >
>> > > Actually:
>> > >
>> > > for (;;)
>> > > ;
>> >
>> > This form will generate a compiler warning, because it looks like a
>> missing loop body. You can silence the warning by this form:
>> >
>> > for (;;) {}
>> >
>> > This makes it clear that you have an explicit body containing no
>> statements.
>>
>> Please fix the style man page then, and make sure bde approves!
>
> One of the examples allows
>
> for (;;)
> stmt;
>
> Using "continue;" as the statement is consistant with that.
Ok, so with approval from a docs/src guy I'd like to commit [1] to
update the style page to use continue; instead of a lone ;
Anyone like to approve/commit?
Chris
[1] http://www.bayofrum.net/~crees/patches/style-empty-loop.diff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839RJQY6hsoryBGR382tQhfVLBRTLeJOPkNntg77KjZ4kg>