Date: Wed, 28 Mar 2018 09:08:19 -0700 From: John Baldwin <jhb@freebsd.org> To: Jeff Roberson <jroberson@jroberson.net> Cc: Li-Wen Hsu <lwhsu@freebsd.org>, "O. Hartmann" <o.hartmann@walstatt.org>, Jeff Roberson <jeff@freebsd.org>, pho@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r331606 - in head/sys: amd64/include i386/include x86/x86 x86/xen Message-ID: <2531747.pQxc7AOloZ@ralph.baldwin.cx> In-Reply-To: <alpine.BSF.2.21.1803271105550.2307@desktop> References: <201803270337.w2R3b4iv035285@repo.freebsd.org> <20180327101309.GA75720@freefall.freebsd.org> <alpine.BSF.2.21.1803271105550.2307@desktop>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, March 27, 2018 11:07:22 AM Jeff Roberson wrote: > On Tue, 27 Mar 2018, Li-Wen Hsu wrote: > > > On Mon, Mar 26, 2018 at 20:35:12 -1000, Jeff Roberson wrote: > >> The patch has been on my branch for weeks and has been tested by a half > >> dozen people. I'm sorry it does not work for you. If you reverted 331605 > >> the change that followed should not have built properly. Did you build > >> cleanly? Can you share your kernel config? > >> > >> I tried with and without EARLY_AP_STARTUP and with and without NUMA. I'm > >> not having any trouble booting. Did you make cleandepend && make depend? > > > > It also hangs in our testing system: > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/6817/console > > https://ci.freebsd.org/job/FreeBSD-head-i386-test/1000/console > > > > It is built cleanly and uses unmodified GENERIC config. > > > > The artifacts used are available here: > > > > https://artifact.ci.freebsd.org/snapshot/head/r331606/amd64/amd64/ > > https://artifact.ci.freebsd.org/snapshot/head/r331606/i386/i386/ > > > > Hope these information help. > > Could someone who was experiencing the hang try the enclosed patch? I can > only verify that it continues to boot for me but I believe this fixes the > bug on other systems. > > I believe the issue was that cpuset_domain[0] was initialized too late on > some systems. It depended on what kind of hardware was present and which > sysinit with SI_ORDER_ANY ran first. Hmm, does this work if you don't use EARLY_AP_STARTUP? I think all_cpus isn't set yet (or only contains the BSP) when cpuset_thread0 is run if you don't have EARLY_AP_STARTUP (and EARLY_AP_STARTUP is only supported on x86 currently) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2531747.pQxc7AOloZ>