Date: Fri, 19 Nov 2010 16:27:27 -0500 From: Attilio Rao <attilio@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215544 - head/sys/kern Message-ID: <AANLkTim5=fXFojYehimtW9B9GDn6hw0U-00E02tDfFCh@mail.gmail.com> In-Reply-To: <201011191617.51552.jhb@freebsd.org> References: <201011191943.oAJJhv3i087205@svn.freebsd.org> <201011191617.51552.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/11/19 John Baldwin <jhb@freebsd.org>: > On Friday, November 19, 2010 2:43:57 pm Attilio Rao wrote: >> Author: attilio >> Date: Fri Nov 19 19:43:56 2010 >> New Revision: 215544 >> URL: http://svn.freebsd.org/changeset/base/215544 >> >> Log: >> Scan the list in reverse order for the shutdown handlers of loaded modules. >> This way, when there is a dependency between two modules, the handler of the >> latter probed runs first. >> >> This is a similar approach as the modules are unloaded in the same >> linkerfile. >> >> Sponsored by: Sandvine Incorporated >> Submitted by: Nima Misaghian <nmisaghian at sandvine dot com> >> MFC after: 1 week >> >> Modified: >> head/sys/kern/kern_module.c >> >> Modified: head/sys/kern/kern_module.c >> ============================================================================== >> --- head/sys/kern/kern_module.c Fri Nov 19 18:59:35 2010 (r215543) >> +++ head/sys/kern/kern_module.c Fri Nov 19 19:43:56 2010 (r215544) >> @@ -46,7 +46,7 @@ __FBSDID("$FreeBSD$"); >> >> static MALLOC_DEFINE(M_MODULE, "module", "module data structures"); >> >> -typedef TAILQ_HEAD(, module) modulelist_t; >> +typedef TAILQ_HEAD(modulelst, module) modulelist_t; > > Is modulelist already taken? If not, we should probably just retire > 'modulelist_t' and replace it with 'struct modulelist'. Note that I used modulelst, not modulelist. Probabilly, if you think the name may be still confusing, we can pickup one another further. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim5=fXFojYehimtW9B9GDn6hw0U-00E02tDfFCh>