Date: Fri, 5 May 2000 19:44:48 -0700 (PDT) From: Kris Kennaway <kris@FreeBSD.org> To: Alexander Langer <alex@big.endian.de> Cc: "Jordan K. Hubbard" <jkh@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libftpio ftpio.c Message-ID: <Pine.BSF.4.21.0005051941060.21805-100000@freefall.freebsd.org> In-Reply-To: <20000505161148.A34126@cichlids.cichlids.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 5 May 2000, Alexander Langer wrote:
> > > Make FTP_PASSIVE_MODE check more specific.
> > > Suggested by: Eric D. Futch <efutch@nyct.net>
> > Thanks, you broke it.
>
> Ok. Analyzed:
>
> FTP_PASSIVE_MODE=yes doesn't work now, maybe you want to add
> two paranthesis and || !strcmp(..., "yes", 3)
This change looks like a violation of POLA - historically, we have never
tested most "feature activation" variables for what they contain, only
whether they exist. Exceptions are things like USA_RESIDENT which must be
set to a defined value (YES or NO), but for the majority of variables you
can't set USE_SOMETHING=no and expect it to do what the english
interpretation of the statement would suggest.
If we're going to change, it should be to recognise certain negative
values so that "FTP_PASSIVE_MODE=damnright" still works as it used to, but
people can do "FTP_PASSIVE_MODE=no" or "NO" to disable it.
Kris
----
In God we Trust -- all others must submit an X.509 certificate.
-- Charles Forsythe <forsythe@alum.mit.edu>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0005051941060.21805-100000>