Date: Sun, 19 Jul 2026 11:40:05 +0200 From: Robert Clausecker <fuz@freebsd.org> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@freebsd.org> Cc: Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 77a201b1705d - main - ministat: parse comma used as decimal delimiter Message-ID: <alybdYKVZEsLFptV@fuz.su> In-Reply-To: <86zeznz6hp.fsf@ltc.des.dev> References: <6a5987fe.3e18c.5660ceff@gitrepo.freebsd.org> <86zeznz6hp.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
I agree. Either adapt the parser to be locale aware (see localeconv(3)) or document that tools must be run in the C locale. But don't try to play Pokémon with separators. It'll blow up horribly. Please revert. Yours, Robert Clausecker Am Sun, Jul 19, 2026 at 11:14:10AM +0200 schrieb Dag-Erling Smørgrav: > Gleb Smirnoff <glebius@FreeBSD.org> writes: > > commit 77a201b1705dbd97ea9ebe5b25b1d4ddac8a7d38 > > Author: Gleb Smirnoff <glebius@FreeBSD.org> > > AuthorDate: 2026-07-17 00:49:55 +0000 > > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > > CommitDate: 2026-07-17 01:40:03 +0000 > > > > ministat: parse comma used as decimal delimiter > > > > This allows to use output of '/usr/bin/time -ao foo' as direct input to > > ministat(1). > > > > While here make diagnostic message more verbose. > > This is wrong. What if delim is ","? The correct solution is to either > run your time command with LANG=C, or post-process the output. > > DES > -- > Dag-Erling Smørgrav - des@FreeBSD.org > > -- () ascii ribbon campaign - for an encoding-agnostic world /\ - against html email - against proprietary attachmentshome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alybdYKVZEsLFptV>