Date: Thu, 7 Aug 2008 18:50:06 GMT From: Alex Kozlov <spam@rm-rf.kiev.ua> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second time Message-ID: <200808071850.m77Io68D025416@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/126324; it has been noted by GNATS.
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Kris Kennaway <kris@FreeBSD.org>, bug-followup@freebsd.org,
spam@rm-rf.kiev.ua
Cc:
Subject: Re: bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second
time
Date: Thu, 7 Aug 2008 21:49:03 +0300
On Thu, Aug 07, 2008 at 07:25:49PM +0200, Kris Kennaway wrote:
> Alex Kozlov wrote:
>
> > Well, as alternative We can just don't touch /tmp if it already mounted.
> This is much better on general grounds.
I post patch for review soon.
> > This also prevent md device leak at least until bin/114468 will be
> > resolved.
>
> I don't like that PR since it introduces a layering violation, and
> doesn't come with a justification of why it is necessary.
>
> Utilities that operate on filesystems shouldn't have knowledge about a
> particular kind of backing store.
I agree that this solution is a little ugly but also true that We need
a simple way to garbage collect md devices.
Current way is even more ugly:
md=$(mount |grep ${mp}|cut -f1 -d' '); umount ${mp}; mdconfig -d -u ${md}
--
Adios
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808071850.m77Io68D025416>