Date: Thu, 2 Dec 2010 08:30:30 GMT From: Sascha Wildner <saw@online.de> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/152768: Weird check in mfi(4) Message-ID: <201012020830.oB28UUkS033357@red.freebsd.org> Resent-Message-ID: <201012020840.oB28eATl001515@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 152768 >Category: kern >Synopsis: Weird check in mfi(4) >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 02 08:40:10 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Sascha Wildner >Release: none :) >Organization: >Environment: >Description: Hi there, I recently ported FreeBSD's mfi(4) driver to DragonFly BSD and when running clang's static analyzer on the kernel, it found: http://yoyodyne.ath.cx/tmp/scan-build-2010-12-01-1/report-tCmTHj.html#EndPath If device is T_DIRECT (0x00) or T_PROCESSOR (0x03) then (device & 0xe0) can't be true. It kinda smells like the intention was something different here, though I'm not sure which, so I thought I'd report it. Kind regards, Sascha >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012020830.oB28UUkS033357>