Date: Wed, 31 Jan 2018 11:57:08 -0500 From: Mark Johnston <markj@FreeBSD.org> To: Kirk McKusick <mckusick@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328383 - head/sbin/fsck_ffs Message-ID: <20180131165708.GA11199@raichu> In-Reply-To: <201801242357.w0ONve5P047566@repo.freebsd.org> References: <201801242357.w0ONve5P047566@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 24, 2018 at 11:57:40PM +0000, Kirk McKusick wrote: > Author: mckusick > Date: Wed Jan 24 23:57:40 2018 > New Revision: 328383 > URL: https://svnweb.freebsd.org/changeset/base/328383 > > Log: > More throughly integrate libufs into fsck_ffs by using its cgput() > routine to write out the cylinder groups rather than recreating the > calculation of the cylinder-group check hash in fsck_ffs. > > No functional change intended. > > Modified: > head/sbin/fsck_ffs/fsck.h > head/sbin/fsck_ffs/fsutil.c > head/sbin/fsck_ffs/gjournal.c > head/sbin/fsck_ffs/setup.c > head/sbin/fsck_ffs/suj.c Hi Kirk, This seems to break recovery of SU+J filesystems after an unclean shutdown. fsck_ffs appears to replay the journal and reports that the filesystem is marked clean, but a subsequent attempt to mount the filesystem rw returns an error. I need to run a full fsck or disable SU journaling in order to recover from a crash without manual intervention in single-user mode.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180131165708.GA11199>