Date: Fri, 3 Jan 1997 11:49:03 +0100 From: j@uriah.heep.sax.de (J Wunsch) To: jkh@freefall.freebsd.org (Jordan K. Hubbard) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c Message-ID: <Mutt.19970103114903.j@uriah.heep.sax.de> In-Reply-To: <199701030713.XAA04264@freefall.freebsd.org>; from Jordan K. Hubbard on Jan 2, 1997 23:13:24 -0800 References: <199701030713.XAA04264@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
As Jordan K. Hubbard wrote: > jkh 97/01/02 23:13:23 > > Modified: usr.sbin/syslogd syslogd.c > Log: > Unlink LogName before attempting to open it. Since we now have a lovely > bug in syslogd which causes it to die after random amounts of time (widely > reported), this at least allows the administrator to easily restart it > without wondering why it simply exits again each time. This change is wrong. We've been there before, and deliberately decided to keep the unlike out, and leave this to /etc/rc, or to the admin to do it. Right now, you've broken logging from savecore(8) which writes to the syslog socket before syslogd is running. sysylogd used to be able to extract its messages from the socket buffer previously (maybe months ago). Don't work around bugs by introducing new bugs. If syslogd dies, it must be investigated. Mine didn't yet, but i've noticed: Jan 1 16:34:09 uriah syslogd: /dev/: Is a directory Jan 1 16:34:09 uriah last message repeated 3 times ...without knowing what went wrong. Too bad that you've also instantly merged this to 2.2. Changes of this kind should at least be discussed and run in -current for a week or two before. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Mutt.19970103114903.j>