Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Feb 2021 19:05:26 +0200
From:      Toomas Soome <tsoome@me.com>
To:        Jakob Alvermark <jakob@alvermark.net>
Cc:        FreeBSD Developers <developers@freebsd.org>, freebsd-current <freebsd-current@freebsd.org>
Subject:   Re: testers needed: loader: use display pixel density for font autoselection
Message-ID:  <30FE8DB4-19C4-4A7E-926C-A790562D09DC@me.com>
In-Reply-To: <59877cd0-781a-4ee9-da3e-8fc80bc92f81@alvermark.net>
References:  <D1E0B15D-5FBF-4E20-A901-A544B4C6FF5C@me.com> <59877cd0-781a-4ee9-da3e-8fc80bc92f81@alvermark.net>

next in thread | previous in thread | raw e-mail | index | archive | help


> On 23. Feb 2021, at 17:53, Jakob Alvermark <jakob@alvermark.net> =
wrote:
>=20
> On 2/23/21 12:27 PM, Toomas Soome via freebsd-current wrote:
>> hi!
>>=20
>> I have done some work to make font pickup a bit smarter (hopefully =
better;), but my own ability to test is limited to one bugged supermicro =
and one MBP with retina display=E2=80=A6
>>=20
>> The phab link ishttps://reviews.freebsd.org/D28849  =
<https://reviews.freebsd.org/D28849>;
>>=20
>> I have built loader binaries as well (bios and uefi):
>> loader_lua<http://148-52-235-80.sta.estpak.ee/loader_lua>;
>> loader_lua.efi<http://148-52-235-80.sta.estpak.ee/loader_lua.efi>;
>>=20
>> To test, you should remove screen.font=3D line from loader.conf and =
test with different resolutions.
>>=20
>> thanks,
>> toomas
>=20
>=20
>=20
> Hi Toomas,
>=20
>=20
> I tested on five different setups.
>=20
> Surface Pro 10.6"@1920x1080:
>=20
> The loader menu looks different, the "FreeBSD" text is on the right =
side of the screen.


I think, this was the lua script bug we did fix not too long time ago.

>=20
> Otherwise, the font size is what I would call a normal size.
>=20
>=20
> Acer laptop 11.6"@1366x768:
>=20
> Menu looks fine. Almost fills the entire screen.
>=20
> The font feels a little too big.


The laptop built in displays usually do not give out EDID (we get =
physical dimensions from EDID), so there we fall back to try to get =
80x25 terminal method.

>=20
>=20
> Thinkpad built in 13"@1920x1080:
>=20
> Menu looks fine, but a little slow.
>=20
> The font size is a little to big for my liking. When drm loads and =
mirrors the screen to my external 27" it looks comically large.
>=20

There is another issue - once DRM will kick in, we should re-consider =
the console attributes, like fonts, but at this time, the kernel itself =
only can use what was built in (8x16), or what loader was offering =
(default if present). So it is up to user to act there.

>=20
> Thinkpad external 24"@1920x1200:
>=20
> Menu looks OK, uses about a quarter of the screen.
>=20
> Font size is fine, but once drm loads it looks a bit squeezed (like =
thin and tall), but I guess that's drm detecting the built in 1920x1080, =
and the external display is stretched.
>=20
>=20
> Thinkpad external 27"@3840x2160:
>=20
> Menu looks OK, uses about a quarter of the screen.
>=20
> Font size is fine.
>=20
> Looking at the dmesg though, it says: VT(efifb): resolution 1920x1080
>=20
>=20
> Jakob
>=20


Those cases .. I suppose the menu was still at left side, not in middle? =
The thing there is, our menu is designed for 80x25 screen, with =
respective constants.=20

many thanks for testing,
toomas




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?30FE8DB4-19C4-4A7E-926C-A790562D09DC>