Date: Mon, 15 Oct 2007 10:06:22 GMT From: kib@FreeBSD.org To: sem@FreeBSD.org, kib@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: kern/116310: [patch] prevent junk lines in log on SMP Message-ID: <200710151006.l9FA6Msh076673@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: [patch] prevent junk lines in log on SMP State-Changed-From-To: open->closed State-Changed-By: kib State-Changed-When: Mon Oct 15 10:03:57 UTC 2007 State-Changed-Why: I think the patch is wrong. You cannot take the (default sleepable) mutex in the printf path, since the function is called from arbitrary kernel context. I do not think that even spin mutex could be used there. The right solution to the problem seems be setting the PRINTF_BUFR_SIZE kernel config option. http://www.freebsd.org/cgi/query-pr.cgi?pr=116310
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710151006.l9FA6Msh076673>