Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Sep 2002 14:58:12 -0700
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        Tony Finch <fanf@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/uudecode uudecode.c
Message-ID:  <20020910145812.B78992@FreeBSD.org>
In-Reply-To: <200209102053.g8AKrkvc055026@freefall.freebsd.org>; from fanf@FreeBSD.org on Tue, Sep 10, 2002 at 01:53:46PM -0700
References:  <200209102053.g8AKrkvc055026@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* De: Tony Finch <fanf@FreeBSD.org> [ Data: 2002-09-10 ]
	[ Subjecte: cvs commit: src/usr.bin/uudecode uudecode.c ]
> fanf        2002/09/10 13:53:46 PDT
> 
>   Modified files:
>     usr.bin/uudecode     uudecode.c 
>   Log:
>   Style: Don't treat pointers as booleans.

Do we have a firm style(9) ruling on that?  There's like two cases I know
of where it's justified, both are code that return pointers, and use 0 / false
internally.  I loathe if(ptr) almost as much as if(foo &bitmask) and if(!strcmp)
-- 
Juli Mallett <jmallett@FreeBSD.org>       | FreeBSD: The Power To Serve
Will break world for fulltime employment. | finger jmallett@FreeBSD.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020910145812.B78992>