Date: Sun, 07 Jan 2024 16:58:44 +0000 From: bugzilla-noreply@freebsd.org To: threads@FreeBSD.org Subject: [Bug 270661] taskqgroup_cpu_create does taskqueue_thread_enqueue not gtaskqueue_thread_enqueue Message-ID: <bug-270661-13406-0IbVL94Jjy@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-270661-13406@https.bugs.freebsd.org/bugzilla/> References: <bug-270661-13406@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270661 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D144e7a72f476f8f8453c40532c6f95c1f= 9add7ae commit 144e7a72f476f8f8453c40532c6f95c1f9add7ae Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2023-12-31 16:36:12 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-01-07 16:56:04 +0000 gtaskqueue: Fix a typo This is a no-op in practice since gtaskqueue_thread_enqueue() and taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create() compares the enqueue callback pointer with gtaskqueue_thread_enqueue(), the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied directly from subr_taskqueue.c and is unused in the gtaskqueue code. Fix it anyway since it's a bug. More generally we really need to consolidate subr_taskqueue.c and subr_gtaskqueue.c. PR: 270661 MFC after: 1 week (cherry picked from commit e1f336704d308679d4178fd5063dba854b22a07b) sys/kern/subr_gtaskqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-270661-13406-0IbVL94Jjy>