Date: Mon, 17 Jul 2017 19:57:36 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 220785] audio/jack: Add and enable COOKEDMODE option, Use GitHub Message-ID: <bug-220785-12827-9fPZvDNMSz@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-220785-12827@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220785 --- Comment #11 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 184447 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=184447 patch > +SUB_FILES= pkg-message Why? The file doesn't seem to contain any %% macros such e.g., %%PREFIX%%. > +DYNSIMD_CONFIGURE_ENABLE=dynsimd > > CFLAGS+= -I${BDB_INCLUDE_DIR} > +COOKEDMODE_CFLAGS+= -DOPTION_COOKEDMODE=1 > LIBS+= -L${BDB_LIB_DIR} > INSTALL_TARGET= install-strip - Rename DYNSIMD to RTCPU which already has default description vi Mk/bsd.options.desc.mk - Don't mix option helpers and generic definitions/flags. It's confusing and breaks existing style in the file. For one, see how other _CONFIGURE_ENABLE are grouped. - Maybe replace += with plain = as _CFLAGS helper already appends (not overrides) the value > +OPTIONS_DEFINE= ALSA DOXYGEN READLINE SNDIO COOKEDMODE > +OPTIONS_DEFINE_i386= ALSA DOXYGEN READLINE SNDIO COOKEDMODE DYNSIMD > +OPTIONS_DEFINE_amd64= ALSA DOXYGEN READLINE SNDIO COOKEDMODE DYNSIMD > +OPTIONS_DEFAULT= READLINE COOKEDMODE > +OPTIONS_DEFAULT_i386= READLINE COOKEDMODE DYNSIMD > +OPTIONS_DEFAULT_amd64= READLINE COOKEDMODE DYNSIMD Can you deduplicate OPTIONS_*_${ARCH} ? Mk/bsd.options.mk already appends (not overrides) arch-specific options. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220785-12827-9fPZvDNMSz>