Date: Sun, 26 Mar 2023 19:08:38 +0200 From: Warner Losh <imp@bsdimp.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "Alexander V. Chernikov" <melifaro@freebsd.org>, Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: a85dcd4ac4b0 - main - netlink: restrict default userland switch to netlink to i386/amd64. Message-ID: <CANCZdfqKrAiDP359ipUti6yDZ8-xHLw0U3ef27t4GvaC-mBfhw@mail.gmail.com> In-Reply-To: <486C839F-181F-4CE8-8510-4A7D4D100FDC@freebsd.org> References: <202303261107.32QB7T7N058867@gitrepo.freebsd.org> <CAPyFy2Bdhi7xWs9-5JzudbVj62GarWeeJ9BwBEK=0smvcT2Dgw@mail.gmail.com> <486C839F-181F-4CE8-8510-4A7D4D100FDC@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, Mar 26, 2023, 6:45 PM Jessica Clarke <jrtc27@freebsd.org> wrote: > On 26 Mar 2023, at 17:17, Ed Maste <emaste@freebsd.org> wrote: > > > > > > On Sun, 26 Mar 2023 at 07:07, Alexander V. Chernikov > > <melifaro@freebsd.org> wrote: > >> > >> The branch main has been updated by melifaro: > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003 > >> > >> commit a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003 > >> Author: Alexander V. Chernikov <melifaro@FreeBSD.org> > >> AuthorDate: 2023-03-26 11:05:21 +0000 > >> Commit: Alexander V. Chernikov <melifaro@FreeBSD.org> > >> CommitDate: 2023-03-26 11:06:53 +0000 > >> > >> netlink: restrict default userland switch to netlink to i386/amd64. > > > > We should keep default options the same for all Tier-1 architectures, > > so amd64 and arm64 should be in sync. > > But also, what’s the technical justification for this change? There > should not be gratuitous differences between architectures like this, > only when there is a reason something shouldn’t be enabled. Why should > x86 (and possibly arm64) get netlink, but not arm/powerpc/riscv? We > have very few machine-dependent defaults in src.opts.mk. If there is no > such justification then please revert this in its entirety, and if > there is such a justification it belongs in a comment above the if. > So if it's a matter of testing, enable it everywhere. We'll get testing. If it's something known to be bad on say riscv64 we should have a bug and reference it in src.opts.mk to document why. If it's just a conservative approach to a roll out, then I'd suggest being less conservative. Warner > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Mar 26, 2023, 6:45 PM Jessica Clarke <<a href="mailto:jrtc27@freebsd.org">jrtc27@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 26 Mar 2023, at 17:17, Ed Maste <<a href="mailto:emaste@freebsd.org" target="_blank" rel="noreferrer">emaste@freebsd.org</a>> wrote:<br> > <br> > <br> > On Sun, 26 Mar 2023 at 07:07, Alexander V. Chernikov<br> > <<a href="mailto:melifaro@freebsd.org" target="_blank" rel="noreferrer">melifaro@freebsd.org</a>> wrote:<br> >> <br> >> The branch main has been updated by melifaro:<br> >> <br> >> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003</a><br>; >> <br> >> commit a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003<br> >> Author: Alexander V. Chernikov <melifaro@FreeBSD.org><br> >> AuthorDate: 2023-03-26 11:05:21 +0000<br> >> Commit: Alexander V. Chernikov <melifaro@FreeBSD.org><br> >> CommitDate: 2023-03-26 11:06:53 +0000<br> >> <br> >> netlink: restrict default userland switch to netlink to i386/amd64.<br> > <br> > We should keep default options the same for all Tier-1 architectures,<br> > so amd64 and arm64 should be in sync.<br> <br> But also, what’s the technical justification for this change? There<br> should not be gratuitous differences between architectures like this,<br> only when there is a reason something shouldn’t be enabled. Why should<br> x86 (and possibly arm64) get netlink, but not arm/powerpc/riscv? We<br> have very few machine-dependent defaults in <a href="http://src.opts.mk" rel="noreferrer noreferrer" target="_blank">src.opts.mk</a>. If there is no<br> such justification then please revert this in its entirety, and if<br> there is such a justification it belongs in a comment above the if.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">So if it's a matter of testing, enable it everywhere. We'll get testing. If it's something known to be bad on say riscv64 we should have a bug and reference it in <a href="http://src.opts.mk">src.opts.mk</a>; to document why. If it's just a conservative approach to a roll out, then I'd suggest being less conservative. </div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqKrAiDP359ipUti6yDZ8-xHLw0U3ef27t4GvaC-mBfhw>