Date: Wed, 30 Apr 2003 09:43:32 +0200 (CEST) From: Harti Brandt <brandt@fokus.fraunhofer.de> To: "M. Warner Losh" <imp@bsdimp.com> Cc: nate@root.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h Message-ID: <20030430093931.V31027@beagle.fokus.fraunhofer.de> In-Reply-To: <20030429.122808.116092806.imp@bsdimp.com> References: <20030429054515.D74EF37B490@hub.freebsd.org> <20030429.122808.116092806.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 29 Apr 2003, M. Warner Losh wrote: MWL>In message: <Pine.BSF.4.21.0304291101001.75697-100000@root.org> MWL>: > 4) Return immediately if gone is true in fxp_ioctl MWL>: > 5) Return immediately if gone is true in fxp_intr MWL>: MWL>: Not sure this approach is necessary. MWL> MWL>I am. Otherwise ioctl panics with recursive locks when the card is MWL>detached. A simple kld_unload if_fxp would provoke these races, MWL>including the recursive lock panic. You can replace the pointers to ioctl and start with pointers to dummy functions. In fact, an if_dead(ifp) function which does just this would be nice to have. harti -- harti brandt, http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.fraunhofer.de, harti@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030430093931.V31027>