Date: Wed, 27 Feb 2002 15:19:04 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Peter Wemm <peter@wemm.org> Cc: Alfred Perlstein <bright@mu.org>, Matthew Dillon <dillon@apollo.backplane.com>, Julian Elischer <julian@elischer.org>, FreeBSD current users <current@FreeBSD.ORG> Subject: Re: controversial fix or some errors breaking LINT Message-ID: <20020227151904.A22221@Odin.AC.HMC.Edu> In-Reply-To: <20020227231509.EB2B93809@overcee.wemm.org>; from peter@wemm.org on Wed, Feb 27, 2002 at 03:15:09PM -0800 References: <20020227225459.GY80761@elvis.mu.org> <20020227231509.EB2B93809@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Feb 27, 2002 at 03:15:09PM -0800, Peter Wemm wrote:
> If there are files that are too hard to fix, or vendor files, or the fix
> isn't clear, we should use the nowerror conf/files* flags.
>
> It is important that we stop new warnings turning up when the compile
> output is so damn large that it hides things.
I definatly agree. The warnings in gif(4) were mostly lame and should
have been fixed, but no one bothered.
> I will do a pass over things now and see what I can do.
Please make sure to test the !SMP case. The following slipped through
the initial sweep:
Index: kern_sig.c
===================================================================
RCS file: /usr/cvs/src/sys/kern/kern_sig.c,v
retrieving revision 1.149
diff -u -r1.149 kern_sig.c
--- kern_sig.c 23 Feb 2002 11:12:54 -0000 1.149
+++ kern_sig.c 26 Feb 2002 19:37:00 -0000
@@ -1233,7 +1233,9 @@
register int prop;
register sig_t action;
struct thread *td;
+#ifdef SMP
struct ksegrp *kg;
+#endif
KASSERT(_SIG_VALID(sig),
("psignal(): invalid signal %d\n", sig));
-- Brooks
--
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8fWlnXY6L6fI4GtQRAhCVAKDMzXnNjSnFUq9PFV8q5Gfc5mxQsQCffNyu
0G182CDT9msYhsN8wMmetBI=
=GAPd
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020227151904.A22221>