Date: Mon, 27 Jul 2026 13:14:28 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: freebsd-current <freebsd-current@freebsd.org> Subject: Re: amd64 boot crash for lack of being set up to use of rtw89; linuxkpi calls on the stack, 0xdeadc0dedeadc13e and such involved, devfs_ioctl with dsw=0xdeadc0dedeadc0de Message-ID: <rp138qp9-76r8-28s6-2non-s4sq36p5pp5n@mnoonqbm.arg> In-Reply-To: <531q4s72-168s-672r-1817-3985905s96o@SerrOFQ.bet> References: <62ded8a9-a1ce-42e8-836b-53b4de21d333@yahoo.com> <531q4s72-168s-672r-1817-3985905s96o@SerrOFQ.bet>
index | next in thread | previous in thread | raw e-mail
On Sat, 25 Jul 2026, Bjoern A. Zeeb wrote:
> Can you test this?
>
> % git diff
> diff --git sys/compat/linuxkpi/common/src/linux_pci.c
> sys/compat/linuxkpi/common/src/linux_pci.c
> index a49254425b5d..b1c28a188b94 100644
> --- sys/compat/linuxkpi/common/src/linux_pci.c
> +++ sys/compat/linuxkpi/common/src/linux_pci.c
> @@ -370,7 +370,7 @@ lkpi_pci_dev_release(struct device *dev)
> */
>
> /* Clear the hierarchy recursively to root. */
> - if (pdev->bus->self != pdev) {
> + if (pdev->bus->self != pdev && pdev->bus->self != NULL) {
> pci_dev_put(pdev->bus->self);
> pdev->bus->self = NULL;
> }
Just for the archives: ths above change is a NOP as pci_dev_put() does
check for the passed in pdev to be != NULL; so contrary to what I have
said in the thread I'll not commit this.
/bz
--
Bjoern A. Zeeb r15:7
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?rp138qp9-76r8-28s6-2non-s4sq36p5pp5n>