Date: Thu, 18 Feb 2016 16:38:45 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org>, ray@FreeBSD.org, Adrian Chadd <adrian.chadd@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress Message-ID: <56C66415.7040407@FreeBSD.org> In-Reply-To: <CAH7qZfuOzAXzmmCBXGr3YcUeJgt420NE%2Bq9E-Xx6GVsoAYk_UA@mail.gmail.com> References: <CAH7qZfuOzAXzmmCBXGr3YcUeJgt420NE%2Bq9E-Xx6GVsoAYk_UA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 2/18/2016 3:57 PM, Maxim Sobolev wrote: > Aleksandr, Adrian, > > I know it's 3 years later, but I really don't know why it's been done > this way. Take a GEOM module and associated usr.bin utility, copy it > verbatim add few lines of code and re-add that as a new module seems > like just laziness and attempt to avoid doing extra work on making > unified code. The same goes for the mkulzma, which is almost 1:1 copy of > the mkuzip. Now people are merging back and forth and I've just spent > few days testing some rather major rework of geom_uzip / mkuzip code not > even realizing that there is its evil twin in the tree. :( r283104 is an example of one of these problems. It was a catch-up of uzip's r268986 done almost a year before. I did comparisons before using uzip last summer and ran across that one. > > https://reviews.freebsd.org/D5333 > > I suggest functionality from both geom_uncompress / mkulzma are folded > now back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuked > afterwards. > > Thanks! > > > > Author: ray > Date: Wed Jan 4 23:39:11 2012 > New Revision: 229537 > URL: http://svn.freebsd.org/changeset/base/229537 > Log: > GEOM_UNCOMPRESS module, can be used with uzip images and with new > ulzma images. > Approved by: adrian (mentor) > Added: > head/sys/geom/uncompress/ > head/sys/geom/uncompress/g_uncompress.c (contents, props changed) > head/sys/modules/geom/geom_uncompress/ > head/sys/modules/geom/geom_uncompress/Makefile (contents, props changed) > Modified: > head/sys/conf/files > head/sys/conf/options > > -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWxmQVAAoJEDXXcbtuRpfPEUQIANj8xQVUQnR2qxXwq499expN 2pS4EDSM4xLOBcNnyGq37Z33T1LuNSUMLeQ660s4RPcfT8YL9gpbRrAXnNELFYa4 R4EFwElr6UEs9w2cgzdQ3RkkCf5OFfIGevA1pm2LUKPUoyR/BsnLEXeoZ8KK+7f2 5SAAz+3C9+77VKzOm0a/x7D9O7m4pTpl24hkNoPpK3+6D974eN1hj8puJHKrtD2W +VRnu/CFVPqNCaasS8o1vQ4xIRS8xXsctOXaactsXmBI7IZC5+XnAO+0Yh21kv35 Cr0zUBjSoPfRNq/DGzn3IeEc1qzUcM1xN1rVW5ELNzppaV5U+5E1ctpau2Sfnas= =h7yM -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56C66415.7040407>