Date: Thu, 18 May 2006 05:51:51 GMT From: Kip Macy <kmacy@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 97394 for review Message-ID: <200605180551.k4I5ppiO020590@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=97394 Change 97394 by kmacy@kmacy_storage:sun4v_rwbuf on 2006/05/18 05:51:04 simplify initial invalidation when setting TSB Affected files ... .. //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/tsb.c#15 edit Differences ... ==== //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/tsb.c#15 (text+ko) ==== @@ -166,12 +166,11 @@ tsb_index = (va >> tsb_shift) & TSB_MASK(tsb); entry = (tte_t *)TLB_PHYS_TO_DIRECT(tsb->hvtsb_pa + 2*tsb_index*sizeof(uint64_t)); tte_tag = (ctx << TTARGET_CTX_SHIFT) | (va >> TTARGET_VA_SHIFT); - tte_data &= ~VTD_V; /* store new value with valid bit cleared * to avoid invalid intermediate value; */ - *(entry + 1) = tte_data; - tte_data |= VTD_V; + *(entry + 1) = 0; + membar(StoreLoad); *(entry) = tte_tag; *(entry + 1) = tte_data; membar(Sync);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200605180551.k4I5ppiO020590>